On 10/10/19 9:28 PM, Bhaskar Chowdhury wrote: > On 20:04 Thu 10 Oct 2019, Randy Dunlap wrote: >> On 10/10/19 7:17 PM, Bhaskar Chowdhury wrote: >>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> >>> --- >>> setlocalversion | 183 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 183 insertions(+) >>> create mode 100755 setlocalversion >> >> Hi, >> I'm pretty sure something is mucked up here. >> >>> diff --git a/setlocalversion b/setlocalversion >> >> but this isn't a diff between those 2 files. >> >> And this diff should be from the top level of the kernel source tree, so it >> should be a diff between a/scripts/setlocalversion and b/scripts/setlocalversion. >> > Right. I have move the original file to top level dir then ... >>> new file mode 100755 >> >> There is already a file scripts/setlocalversion, so this "new file" is strange. >> > It is indeed..because of my stupidity ..as I said removed that file and > made the patch...heck > >> Also, the patch subject should be something like: >> [PATCH] scripts: fix shell syntax >> > Doesn't the subject catch it from commit message?? I don't quite follow that, but anyway my answer is No. >> And note that the shell in this case is /bin/sh, not necessarily bash. >> Actually we prefer to make patches that remove bashisms in many cases. >> > Do you want me drop this one ? Can you be specific Randy, please, if it > is not what is need , no point wasting time on it. Sorry, I can't tell without seeing the actual changes in a corrected patch/diff. >> One more: you should Cc: the kbuild maintainer on patches that he might apply/merge. >> > > I did , I believe ..both the maintainers . Nope. Only the linux-kbuild mailing list, no maintainers that I can see. -- ~Randy
