+++ Masahiro Yamada [03/10/19 16:58 +0900]:
I was hit by some problems caused by the module namespace feature that was merged recently. At least, the breakage of external module builds is a fatal one. I just took a look at the code closer, and I noticed some more issues (some are nit-picking). V2: - I dropped "module: avoid code duplication in include/linux/export.h" because Matthias offered to refactor the code by himself. - V1 missed the problem when a symbol is preloaded before sym_add_exported() is called. I fixed it too.
Hi Masahiro! Thanks for the v2. I've queued this up in the module tree with the intention of getting the fixes in for -rc3. Matthias is working on some modpost fixes that would get rid of the __ksymtab_<symbol>.<ns>/__ksymtab_<ns>.<symbol> naming scheme altogether in favor of just getting the namespace string from __kstrtabns and __ksymtab_strings -- this may render patch 1 unnecessary. But since we want to fix this asap, we can just keep it and apply Matthias's fix on top later. Thanks! Jessica
