On Tue, Oct 1, 2019 at 11:16 PM Björn Töpel <bjorn.topel@xxxxxxxxx> wrote: > > On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > Hi Bjorn > > > > On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel <bjorn.topel@xxxxxxxxx> wrote: > > > > [...] > > > subdir-$(CONFIG_SAMPLE_VFS) += vfs > > > +subdir-$(CONFIG_SAMPLE_BPF) += bpf > > > > > > Please keep samples/Makefile sorted alphabetically. > > > > Thank you, I'll address that in the v2! > > > > > > > > > I am not checking samples/bpf/Makefile, but > > allmodconfig no longer compiles for me. > > > > > > > > samples/bpf/Makefile:209: WARNING: Detected possible issues with include path. > > samples/bpf/Makefile:210: WARNING: Please install kernel headers > > locally (make headers_install). > > error: unable to create target: 'No available targets are compatible > > with triple "bpf"' > > 1 error generated. > > readelf: Error: './llvm_btf_verify.o': No such file > > *** ERROR: LLVM (llc) does not support 'bpf' target > > NOTICE: LLVM version >= 3.7.1 required > > So, samples/bpf intentionally opts out the normal build because most of people fail to build it. It must be fixed somehow before supporting it in samples/Makefile. > Yes, the BPF samples require clang/LLVM with BPF support to build. Any > suggestion on a good way to address this (missing tools), better than > the warning above? After the commit 394053f4a4b3 ("kbuild: make single > targets work more correctly"), it's no longer possible to build > samples/bpf without support in the samples/Makefile. You can with "make M=samples/bpf" -- Best Regards Masahiro Yamada