On Fri, Aug 30, 2019 at 1:09 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Thu, 2019-08-29 at 14:02 +0200, Michal Suchanek wrote: > > In particular the default value of 3 does not match the comments like > > /* falls through to do foobar */ > > How many comments are there like this in the kernel? +1 Given we are trying to move to attr-only and therefore -Wimplicit-fallthrough=5, going back a level needs to be backed by a good argument. It would be way better to fix those comments instead. Cheers, Miguel
