On Thu, Aug 29, 2019 at 2:44 AM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Wed, Aug 28, 2019 at 10:39 AM Nick Desaulniers > <ndesaulniers@xxxxxxxxxx> wrote: > > > > On Wed, Aug 28, 2019 at 9:45 AM Miguel Ojeda > > <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > > > > > On Wed, Aug 28, 2019 at 6:21 PM Masahiro Yamada > > > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > > > > > Applied to linux-kbuild. Thanks. > > > > > > > > (If other clang folks give tags, I will add them later.) > > > > > > Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> > > > > I verified that GCC didn't get support for -Wimplicit-fallthrough > > until GCC ~7.1 release, so the cc-option guard is still required. > > Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > Thanks for the patch Nathan. > > Also, there's an inconsistency between Makefile vs > scripts/Makefile.extrawarn that's been bugging me: it seems we enable > GCC only flags in Makefile, then disable certain Clang flags in > scripts/Makefile.extrawarn. All the flags listed in scripts/Makefile.extrawarn depend on W= option. The options in Makefile are passed irrespective of W=. There is no inconsistency. > Not necessary to fix here and now, but I > hope one day to have one file that has all of the compiler specific > flags in one place (maybe its own file), so I only have to look in one > place. I know, I know, "patches welcome." ;) > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada
