On Tue, 2019-08-13 at 23:01 +0900, Masahiro Yamada wrote: > On Tue, Aug 13, 2019 at 3:13 PM Knut Omang <knut.omang@xxxxxxxxxx> wrote: > > > > C++ libraries interfacing to C APIs might sometimes need some glue > > logic more easily written in C. > > Allow a C++ library to also contain 0 or more C objects. > > > > Also fix rules for both C and C++ shared libraries: > > - C++ shared libraries depended on .c instead of .cc files > > - Rules were referenced as -objs instead of the intended > > -cobjs and -cxxobjs following the pattern from hostprogs*. > > > > Signed-off-by: Knut Omang <knut.omang@xxxxxxxxxx> > > > How is this patch related to the rest of this series? This is just my (likely naive) way I to get what I had working using autotools in the Github version of KTF) translated into something comparable using kbuild only. We need to build a shared library consisting of a few C++ files and a very simple C file, and a couple of simple binaries, and the rule in there does seem to take .c files and subject them to the C++ compiler, which makes this difficult to achieve? > This patch breaks GCC-plugins. > Did you really compile-test this patch before the submission? Sorry for my ignorance here: I ran through the kernel build and installed the resulting kernel on a VM that I used to test this, if that's what you are asking about? Do I need some unusual .config options or run a special make target to trigger the problem you see? I used a recent Fedora config with default values for new options, and ran the normal default make target (also with O=) and make selftests to test the patch itself. Thanks, Knut > -- > Best Regards > > Masahiro Yamada
