On Sat, Aug 10, 2019 at 06:11:10PM +0900, Masahiro Yamada wrote: > On Fri, Aug 9, 2019 at 7:27 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > > When we execute make after merging the configurations we ignore any > > errors it produces causing whatever is running merge_config.sh to be > > unaware of any failures. This issue was noticed by Guillaume Tucker > I am not a big fan of this way of fixing. > [1] 'set -e' is useful to catch any error in this script. Right, that was actually my first thought but since there was a handler and it was already being called directly this must be a deliberate style so I did things this way in order to fit in with the existing style :/ > [2] I think trapping only EXIT is smarter. > The clean() help will be invoked when this script exits > for whatever reason; the temporary files will be cleaned up > when the script is interrupted, errors-out, or finishes > successfully. > I would change like follows: That works for me, Reviewed-by: Mark Brown <broonie@xxxxxxxxxx> Tested-by: Mark Brown <broonie@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
