On Thu, Aug 08, 2019 at 03:12:47PM +0200, Enrico Weigelt, metux IT consult wrote: > On 06.08.19 19:12, Javier Martinez Canillas wrote: > > > Right, we could add a macro for that. Although it should probably be called > > I2C_OF_MODULE_DEVICE_TABLE() or something like that since is specific to OF. > > At that point it should be completely noop when OF is disabled, so we > also can get rid of many ifdef's. Why? > I've got some patch somewhere for introducing a MODULE_OF_TABLE() macro > as replacement for many MODULE_DEVICE_TABLE(of, ...) cases, which noops > when CONFIG_OF is disabled. (and similar ones for other table types). It's simple wrong to have #ifdef CONFIG_OF without counterpart of_match_ptr(). And taking into consideration that ID table itself doesn't depend to OF at all, why not simple drop that #ifdef and of_match_ptr() all together? -- With Best Regards, Andy Shevchenko
