Masahiro, On Sun, 28 Jul 2019, Masahiro Yamada wrote: > > Since CONFIG_PREEMPTION was introduced after -rc1, > I think this should be queued on top of -rc2. Right. Are you picking it up? > > -#ifdef CONFIG_PREEMPT > > -#define MODULE_VERMAGIC_PREEMPT "preempt " > > +#ifdef CONFIG_PREEMPTION > > +# ifdef CONFIG_PREEMPT > > +# define MODULE_VERMAGIC_PREEMPT "preempt " > > +# else > > +# define MODULE_VERMAGIC_PREEMPT "preempt_rt " > > +# endif > > #else > > -#define MODULE_VERMAGIC_PREEMPT "" > > +# define MODULE_VERMAGIC_PREEMPT "" > > Maybe, is the following more readable? > > #if defined(CONFIG_PREEMPT_RT) > #define MODULE_VERMAGIC_PREEMPT "preempt_rt " > #elif defined(CONFIG_PREEMPT) > #define MODULE_VERMAGIC_PREEMPT "preempt " > #else > #define MODULE_VERMAGIC_PREEMPT "" > #endif Doh. That's obvious. Must be a result of the heat wave we had. Will send a V2. Thanks, tglx