Hi Jan, On Thu, Jul 25, 2019 at 5:39 PM Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote: > > > > This affects also external modules builds: I have patterns here that do > > [Makefile] > subdir-y := some-module > > [some-module/Makefile] > obj-m := some-module.o > > and since this patch, the final some-module.ko is no longer built. Am I missing > something in the kbuild makefiles, or is this a regression? Thanks for the report. Interesting. I have never imagined that Makefiles were written like that. I just wrote a fix-up, but I have not determined to apply it. https://patchwork.kernel.org/patch/11059033/ It is easy to fixup your Makefile, though. -- Best Regards Masahiro Yamada