On Sat, Jul 20, 2019 at 6:12 PM Mike Lothian <mike@xxxxxxxxxxxxxx> wrote: > > On Wed, 17 Jul 2019 at 08:57, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > > On Wed, 17 Jul 2019, Masahiro Yamada wrote: > > > On Wed, Jul 17, 2019 at 4:47 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > > So instead of dealing with attempts to duct tape gold support without > > > > understanding the root cause and without support from the gold folks, fail > > > > the build when gold is detected. > > > > > > > > > > The code looks OK in the build system point of view. > > > > > > Please let me confirm this, just in case: > > > For now, we give up all architectures, not only x86, right? > > > > Well, that's the logical consequence of a statement which says: don't use > > gold for the kernel. > > > > > I have not not heard much from other arch maintainers. > > > > Cc'ed linux-arch for that matter. > > > > Thanks, > > > > tglx > > Hi > > I've done a bit more digging, I had a second machine that was building > Linus's tree just fine with ld.gold > > I tried forcing ld.bfd on the problem machine and got this: > > ld.bfd: arch/x86/boot/compressed/head_64.o: warning: relocation in > read-only section `.head.text' > ld.bfd: warning: creating a DT_TEXTREL in object > > I had a look at the differences in the kernel configs and noticed this: > > CONFIG_RANDOMIZE_BASE=y > CONFIG_X86_NEED_RELOCS=y > CONFIG_PHYSICAL_ALIGN=0x1000000 > CONFIG_DYNAMIC_MEMORY_LAYOUT=y > CONFIG_RANDOMIZE_MEMORY=y > CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING=0x0 > > Unsetting CONFIG_RANDOMIZE_BASE=y gets things working for me with ld.gold again Right. I was able to build with ld.gold So, we can use gold, depending on the kernel configuration. > In light of this - can we drop this patch? -- Best Regards Masahiro Yamada
