Hi Masahiro. On Fri, Jun 28, 2019 at 11:04:33AM +0900, Masahiro Yamada wrote: > The assembler files in the kernel are *.S instead of *.s, so they must > be preprocessed. Hence, we always use $(CC) as an assembler driver. > > $(AS) is almost unused in Kbuild. As of writing, there is just one user. > > $ git grep '$(AS)' -- :^Documentation > drivers/net/wan/Makefile: AS68K = $(AS) > > The documentation about *_AFLAGS* sounds like the flags were passed > to $(AS). This is somewhat misleading since we do not invoke $(AS) > directly. Thanks, another of your many nice cleanups. > AFLAGS_KERNEL > -------------------------------------------------- > -Additional options for $(AS) when used for assembler > -code for code that is compiled as built-in. > +Additional options when used for assembling code that is compiled as built-in. To me reading "assembling code" make me think of something else than the assembler. It would be nice to spell out that we talk about the assembler everywhere. Even though the assembler is invoked via gcc. This comments applies to a few places, some where "assembling" was used in the old text. Other than this - looks good! Sam
