On Tue, 2019-06-25 at 12:06 -0500, Gustavo A. R. Silva wrote: > > On 6/25/19 11:52 AM, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we are expecting to fall through. > > [] > > > This patch is part of the ongoing efforts to enable > > > -Wimplicit-fallthrough. > > > > Just enable the thing already. > > > > If you stopped trying to do it all yourself, others > > What are you talking about? > > Anyone can enable it, I'm adding this to every commit: > > Warning level 3 was used: -Wimplicit-fallthrough=3 No one does that by default and almost no one is helping eliminate these. Not even on th Almost no one uses make W=<levels> either as it's generally extremely noisy and can emit a lot of false positives. > And I'll send a PR with a proper patch for the Makefile > during the next merge window. That's great. > If had the power I would have enabled this option since day 1, > so every developer can take care of their own code. You have always had the power to send a patch. You also seem to believe the build needs to be completely clean before enabling the switch. I don't. > Lately, you are not being of much help, Joe. <smile> What kind of help are you expecting? I'm not submitting patches adding fallthough comments as I think that's not a good form. I've said so repeatedly. I believe I suggested months ago you default enable the compiler switch. So it's up to you to either do it or not.
