On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote: > On Fri, May 17, 2019 at 10:51 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote: > > > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > > > > > > > Right; if there is anything you can reproduce on linus.git I'll happily > > > > have a look. If it doesn't reproduce all you have to do is find the > > > > patches that make it work and ask Greg. > > > > > > Just to clarify: Linus' master is clean of these issues with GCC 9.1.1. > > > > Great! Care to find the patches that did that work and send me the git > > commit ids so that I can queue them up? I don't have gcc9 here yet on > > my systems, so I can not test for this. > > I am unsure about the perf and the objtools parts (Peter/Josh?), but > about the -Wmissing-attributes I cleaned, they were these: > > a6e60d84989f ("include/linux/module.h: copy __init/__exit attrs to > init/cleanup_module") That patch I applied now. > c0d9782f5b6d ("Compiler Attributes: add support for __copy (gcc >= 9)") This one will take some work to backport, let me see what is needed here... > ff98e20ef208 ("lib/crc32.c: mark crc32_le_base/__crc32c_le_base > aliases as __pure") I'll get to this as well. thanks, greg k-h