> On Thu, May 9, 2019 at 1:49 PM Nathan Chancellor > <natechancellor@xxxxxxxxx> wrote: > > > > This is no longer a valid option in clang, it was removed in 3.5, which > > we don't support. > > > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 lol, good catch. Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > Cool. > > Can you test with -mglobal-merge (inverted -mno-global-merge) which is > default for Clang? Looks like these were added in r234668 in 2015, which would've been Clang 3.6.2, according to: http://releases.llvm.org/ I'd be fine with dropping the option check there. There's a few here (-Qunused-arguments) that don't need cc-option checks. I recommend someone audit all of them, rather than send a bunch of little patches. -- Thanks, ~Nick Desaulniers
