On 4/10/19 8:32 PM, Masahiro Yamada wrote:
On Thu, Apr 11, 2019 at 12:52 AM Joe Lawrence <joe.lawrence@xxxxxxxxxx> wrote:
From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
replacing hard-coded values in kernel/livepatch/core.c.
[ ... snip ... ]
>>
diff --git a/include/uapi/linux/livepatch.h b/include/uapi/linux/livepatch.h
new file mode 100644
index 000000000000..bb86243de805
--- /dev/null
+++ b/include/uapi/linux/livepatch.h
@@ -0,0 +1,17 @@
+/* SPDX-License-Identifier: GPL-2.0 */
In my understanding, UAPI headers should be licensed under:
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
Good eye, that is an interesting licensing detail. Easy enough to
update assuming Josh (original author) is fine with adding the modifier.
+
+/*
+ * livepatch.h - Kernel Live Patching Core
+ *
+ * Copyright (C) 2016 Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
+ */
+
+#ifndef _UAPI_LIVEPATCH_H
+#define _UAPI_LIVEPATCH_H
+
+#include <linux/types.h>
Why is this include needed?
+#define KLP_RELA_PREFIX ".klp.rela."
+#define KLP_SYM_PREFIX ".klp.sym."
These do not depend on <linux/types.h>
Hmmm, types.h has been included since v1, but I just verified that
removing it results in a clean build, so you are correct that it is
(now) unnecessary.
Thanks,
-- Joe
