On Sun, Mar 17, 2019 at 8:25 PM Stefano Brivio <sbrivio@xxxxxxxxxx> wrote: > > On Sun, 17 Mar 2019 18:11:49 +0100 > Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote: > > > And in this case it seems to be working as intended bisecting it to a > > release tag. > > I guess what went wrong here is that it had to skip quite a few > commits, and the result isn't relevant anymore. Maybe you could improve > this by handling a: > > all runs: boot failed: can't ssh into the instance > > case as bad revision? And, also, if scp times out (as it did on > 912964eacb11), keep retrying instead of marking the revision as good? Skipping revisions does not make the result wrong. In the worst case git bisect will point to a range of commits. But marking non-building/booting revisions as bad can actually diverge bisection in the wrong direction and will result in pointing to completely irrelevant commits. git skip is meant exactly for such cases. And in this case, skipping did not affect the process, it just needed to do few more additional steps.
