On Mon, Feb 11, 2019 at 8:05 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > On Mon, Feb 11, 2019 at 4:33 PM Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > [ ... ] > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/342 > > > > > Suggested-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > --- > > > > > Makefile | 3 +++ > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > diff --git a/Makefile b/Makefile > > > > > index 0eae4277206e..6307c17259ea 100644 > > > > > --- a/Makefile > > > > > +++ b/Makefile > > > > > @@ -502,6 +502,9 @@ endif > > > > > CLANG_FLAGS += -no-integrated-as > > > > > KBUILD_CFLAGS += $(CLANG_FLAGS) > > > > > KBUILD_AFLAGS += $(CLANG_FLAGS) > > > > > +ifneq ($(shell $(LD) --version 2>&1 | head -n 1 | grep LLD),) > > > > > +CLANG_FLAGS += -fuse-ld=lld > > > > > > Sorry, Sedat reports [0] that this is not quite correct; if $(LD) > > > matches LLD, then we need to set -fuse-ld=$(LD), not -fuse-ld=lld, > > > since you may have lld installed as lld-7 or lld-8, for example: > > > https://github.com/ClangBuiltLinux/linux/issues/358 > > > > > > Hmm, $(LD) might be a full path. > > > > Looks like Clang can take a full-path for -fuse-ld=, > > but does it work for GCC? > > > > Nope. GCC expects "-fuse-ld={bfd,gold,lld} ". > Adding suffix "$-VER" was not recognized while building a > llvm-toolchain, so I guess this will be the same for the Linux kernel > side. Well for now, let's add support for just `ld.lld` since a build of llvm will create such a symlink. If folks really need to differentiate between different versions of lld, let's cross that bridge when we get there. -- Thanks, ~Nick Desaulniers
