On Thu, Feb 7, 2019 at 9:51 PM Nathan Chancellor <natechancellor@xxxxxxxxx> wrote: > > On Thu, Feb 07, 2019 at 02:01:51PM -0800, ndesaulniers@xxxxxxxxxx wrote: > > This is needed because clang doesn't select which linker to use based on > > $LD but rather -fuse-ld=$(LD). This is problematic especially for > > cc-ldoption, which checks for linker flag support via invoking the > > compiler, rather than the linker. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/342 > > Suggested-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > --- > > Makefile | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Makefile b/Makefile > > index 0eae4277206e..6307c17259ea 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -502,6 +502,9 @@ endif > > CLANG_FLAGS += -no-integrated-as > > KBUILD_CFLAGS += $(CLANG_FLAGS) > > KBUILD_AFLAGS += $(CLANG_FLAGS) > > +ifneq ($(shell $(LD) --version 2>&1 | head -n 1 | grep LLD),) > > +CLANG_FLAGS += -fuse-ld=lld > > +endif > > This section needs to be moved up above KBUILD_CFLAGS otherwise it never > actually gets passed along. Great catch! I had that correct in my Pixel kernel patches; messed that up forward porting them. Included in v2 (sending imminently). -- Thanks, ~Nick Desaulniers
