> On Dec 17, 2018, at 8:03 AM, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > This series reverts the in-kernel workarounds for inlining issues. > > The commit description of 77b0bf55bc67 mentioned > "We also hope that GCC will eventually get fixed,..." > > Now, GCC provides a solution. > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fonlinedocs%2Fgcc%2FExtended-Asm.html&data=02%7C01%7Cnamit%40vmware.com%7Cc43f433d8c6244de15f108d6643a49e4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636806598899962669&sdata=88UJ25RoiHik9vTCJKZV6%2F7xpzCGsvKb9LFg1kfEYL0%3D&reserved=0 > explains the new "asm inline" syntax. > > The performance issue will be eventually solved. > > [About Code cleanups] > > I know Nadam Amit is opposed to the full revert. My name is Nadav. > He also claims his motivation for macrofying was not only > performance, but also cleanups. Masahiro, I understand your concerns and criticism, and indeed various alternative solutions exist. I do have my reservations about the one you propose, since it makes coding more complicated to simplify the Make system. Yet, more important, starting this discussion suddenly now after RC7 is strange. Anyhow, since it’s obviously not my call, please don’t make it sound as if I am a side in the decision.
