Hi Sam, On Fri, Dec 7, 2018 at 3:06 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > On Wed, Dec 05, 2018 at 08:28:05PM +0900, Masahiro Yamada wrote: > > Some time ago, Sam pointed out a certain degree of overwrap between > > generic-y and mandatory-y. (https://lkml.org/lkml/2017/7/10/121) > > > > I a bit tweaked the meaning of mandatory-y; now it defines the minimum > > set of ASM headers that all architectures must have. > > > > If arch does not have specific implementation of a mandatory header, > > Kbuild will let it fallback to the asm-generic one by automatically > > generating a wrapper. This will allow to drop lots of redundant > > generic-y defines. > > > > Previously, "mandatory" was used in the context of UAPI, but I guess > > this can be extended to kernel space ASM headers. > > > > Suggested-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > Nice work! > > For the full series: > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Have you considered to warn if generic-y contains a header listed > in mandatory-y - to prevent that they sneak back in. > And to catch when we lift a header from available to mandatory. Yes, I also thought of this, and probably we should do it. -- Best Regards Masahiro Yamada
