Hi Sam, On Sat, Nov 17, 2018 at 5:01 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > Hi Masahiro > > On Thu, Nov 15, 2018 at 05:27:10PM +0900, Masahiro Yamada wrote: > > Let $(CC) compile objects into normal files *.o instead of .tmp_*.o > > whether CONFIG_MODVERSIONS is enabled or not. This will help simplify > > build rules a lot. > > Another approach would be to move more of the build stuff to > one or a few build scripts. Shifting code from Makefile to a shell script will be another clean-up. This patch is addressing a different problem. See this code in Malefile.build ifdef CONFIG_MODVERSIONS objtool_o = $(@D)/.tmp_$(@F) else objtool_o = $(@) endif cmd_cc_o_c writes an object into a different file name depending CONFIG_MODVERSIONS, which makes difficult for other actions to manipulate the object in a consistent manner. I will clarify this in the commit log in v2. Thanks. > Using build scripts makes is much easier to add comments and > still keep it readable. > And when the build logic list a set of serialized actions > they thay can be included in a build script nicely. > > But that said - I also like the simplifications you made. > Everytime you trim the core kbuild files it is a win for > readability. > > Sam -- Best Regards Masahiro Yamada
