From: Masahiro Yamada Sent: November 16, 2018 at 7:37:46 AM GMT > To: Nadav Amit <namit@xxxxxxxxxx> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, H. Peter Anvin <hpa@xxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, Linux Kbuild mailing list <linux-kbuild@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S > > > On Thu, Nov 15, 2018 at 1:01 PM Nadav Amit <namit@xxxxxxxxxx> wrote: >> Changes in macros.S should trigger the recompilation of all C files, as >> the macros might need to affect their compilation. >> >> Acked-by: Ingo Molnar <mingo@xxxxxxxxxx> >> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx> >> --- > > When we talked about this last time, > we agreed to not do this > because a single line change in asm headers > would cause global rebuilding. > > Did you change your mind? I was wrong (and you were right? I don’t quite remember). Anyhow, another patch I work on made me realize how wrong I was. If required, we can extract the macros from some of the header files into separate header files to prevent unnecessary rebuilds. Thanks, Nadav
