On Tue, Oct 30, 2018 at 3:27 AM Petr Vorel <petr.vorel@xxxxxxxxx> wrote:
>
> Hi Masahiro,
>
> > Please send v2 with the commit log properly filled.
> OK I'll do.
>
> > I will take my credit as Suggested-by.
> Sure :).
>
> > > > +# Check the environment variable "CONFIG_" for the config option prefix.
> > > > +# If unset, the default is "CONFIG_".
> > > > +: ${CONFIG_=CONFIG_}
> > > Although I guess this could be less cryptic:
> > > CONFIG_="${CONFIG_:-CONFIG_}"
>
> > You should not use the colon
> > because we want to allow the environment variable
> > 'CONFIG_' being set as empty.
> How about having default 'CONFIG_' and if it's empty change it to
> '[A-Z0-9_]\+' ?
No, I'd like to have the same rule for prefix.
> I know, it's different from C definition in lkc.h, but IMHO it'd
> make sense. But I guess you prefer your suggestion CONFIG_PREFIX=${CONFIG_-CONFIG_}
Yeah, I prefer this.
> > In fact, Buildroot uses empty prefix instead of "BR2_".
> > In my understanding, Buildroot just has a convention where
> > symbols in Config.in files start with "BR2_".
> IMHO buildroot uses 'BR2_' prefix. That's what we want to use with
> merge_config.sh.
Yes, you can use 'BR2_' prefix for merge_config.
I just wanted to point out that
Buildroot's own patch specifies the prefix as empty
wrt the kconfig binary.
https://github.com/buildroot/buildroot/blob/2018.08.2/support/kconfig/patches/10-br-build-system.patch#L32
>
> Kind regards,
> Petr
--
Best Regards
Masahiro Yamada
