On Wed, Oct 24, 2018 at 1:05 PM Leonardo Bras <leobras.c@xxxxxxxxx> wrote:
>
> Changes the parameter name to avoid shadowing a variable.
>
> Signed-off-by: Leonardo Bras <leobras.c@xxxxxxxxx>
For this one, I'd rather like to see code refactoring
than renaming the variable.
I will take a closer look.
> ---
> scripts/mod/modpost.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 0d998c54564d..368fe42340df 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -2228,13 +2228,13 @@ static int add_versions(struct buffer *b, struct module *mod)
> }
>
> static void add_depends(struct buffer *b, struct module *mod,
> - struct module *modules)
> + struct module *module_list)
> {
> struct symbol *s;
> struct module *m;
> int first = 1;
>
> - for (m = modules; m; m = m->next)
> + for (m = module_list; m; m = m->next)
> m->seen = is_vmlinux(m->name);
>
> buf_printf(b, "\n");
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
