Re: [PATCH v2] kallsyms: reduce size a little on 64-bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-09-03 21:09 GMT+09:00 Jan Beulich <JBeulich@xxxxxxxx>:
> Both kallsyms_num_syms and kallsyms_markers[] don't really need to use
> unsigned long as their (base) types; unsigned int fully suffices.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: Drop unrelated hunk.
> ---

Applied to linux-kbuild/fixes.  Thanks!


>  kernel/kallsyms.c  |    4 ++--
>  scripts/kallsyms.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> --- 4.19-rc2/kernel/kallsyms.c
> +++ 4.19-rc2-kallsyms-reduce-size/kernel/kallsyms.c
> @@ -37,7 +37,7 @@ extern const u8 kallsyms_names[] __weak;
>   * Tell the compiler that the count isn't in the small data section if the arch
>   * has one (eg: FRV).
>   */
> -extern const unsigned long kallsyms_num_syms
> +extern const unsigned int kallsyms_num_syms
>  __attribute__((weak, section(".rodata")));
>
>  extern const unsigned long kallsyms_relative_base
> @@ -46,7 +46,7 @@ __attribute__((weak, section(".rodata"))
>  extern const u8 kallsyms_token_table[] __weak;
>  extern const u16 kallsyms_token_index[] __weak;
>
> -extern const unsigned long kallsyms_markers[] __weak;
> +extern const unsigned int kallsyms_markers[] __weak;
>
>  /*
>   * Expand a compressed symbol data into the resulting uncompressed string,
> --- 4.19-rc2/scripts/kallsyms.c
> +++ 4.19-rc2-kallsyms-reduce-size/scripts/kallsyms.c
> @@ -405,7 +405,7 @@ static void write_src(void)
>         }
>
>         output_label("kallsyms_num_syms");
> -       printf("\tPTR\t%u\n", table_cnt);
> +       printf("\t.long\t%u\n", table_cnt);
>         printf("\n");
>
>         /* table of offset markers, that give the offset in the compressed stream
> @@ -434,7 +434,7 @@ static void write_src(void)
>
>         output_label("kallsyms_markers");
>         for (i = 0; i < ((table_cnt + 255) >> 8); i++)
> -               printf("\tPTR\t%d\n", markers[i]);
> +               printf("\t.long\t%u\n", markers[i]);
>         printf("\n");
>
>         free(markers);
>
>
>
>



-- 
Best Regards
Masahiro Yamada



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux