Hi. 2018-07-04 8:34 GMT+09:00 Laura Abbott <labbott@xxxxxxxxxx>: > > The vDSO needs to have a unique build id in a similar manner > to the kernel and modules. Use the build salt macro. > > Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx> > --- > v5: I was previously focused on x86 only but since powerpc gave a patch, > I figured I would do arm64 since the changes were also fairly simple. > --- > arch/arm64/kernel/vdso/note.S | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/vdso/note.S b/arch/arm64/kernel/vdso/note.S > index b82c85e5d972..2c429dfd3f45 100644 > --- a/arch/arm64/kernel/vdso/note.S > +++ b/arch/arm64/kernel/vdso/note.S > @@ -22,7 +22,10 @@ > #include <linux/uts.h> > #include <linux/version.h> > #include <linux/elfnote.h> > +#include <linux/build-salt.h> > > ELFNOTE_START(Linux, 0, "a") > .long LINUX_VERSION_CODE > ELFNOTE_END > + > +BUILD_SALT; I think this works, but I prefer no-semicolon in assembly files. For coding consistency, I want ';' as statement delimiter in .c files. But, only new line after each statement in .S files. For example, in arch/x86/xen/xen-head.S I see no semicolon after ELFNOTE(). I found this: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473k/dom1359731141352.html It says ';' starts a comment line although it is not the case of GAS. Same for 3/4. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
