On 06/12/2018 12:06 PM, Dirk Gouders wrote: > This patch adds boundary checks for nconf's i-search pattern. > > Further, the pattern buffer is always bzero'ed when '/' is > pressed, so the second line in the code below was not needed (and > otherwise wouldn't have worked as expected): > > state->pattern[strlen(state->pattern)] = c; > state->pattern[strlen(state->pattern)] = '\0'; > > Finally, the pattern length was reduced to a length that still > seems sufficient but will not fill more than the top line of the > screen, thus eliminating special treatment needs on resizes or normal > exit of i-search. > > Signed-off-by: Dirk Gouders <dirk@xxxxxxxxxxx> > --- > Changes in v2: Correct S-O-B line, remove double search from subject. > --- > scripts/kconfig/nconf.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Hi Dirk, For v1 of the patch: no, I wasn't using PageUp/PageDown, just the up/down arrow keys. Maybe I'm confused about /search in nconfig. nconfig Help says: ││ Start incremental, case-insensitive search for STRING in menu entries, ││ ││ no regex support, STRING is displayed in upper left corner ││ ││ </>STRING ││ ││ Remove last character <Backspace> ││ ││ Jump to next hit <Down> ││ ││ Jump to previous hit <Up> ││ ││ Exit menu search mode </> <Esc> First of all, does this only search in the Kconfig prompt strings? (from top-level menu) OK, I want to search for "debug", so I enter "/debug" and the upper left corner displays: searching: debug The nconfig highlight bar goes to the Device Drivers menu. That's it. It hasn't found "debug" (it found "de" AFAICT). Using Up/Down arrow keys don't do anything. I gave up. What am I doing wrong? thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
