Re: [PATCH v2 2/2] kbuild: Fix indent in help

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-06-01 14:50 GMT+09:00 Petr Vorel <pvorel@xxxxxxx>:
> + move last word of nconfig help to the previous line
>
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
>  scripts/kconfig/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 36b092150c45..fda6b1734ee0 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -151,8 +151,7 @@ clean-dirs += tests/.cache
>  # Help text used by make help
>  help:
>         @echo  '  config          - Update current config utilising a line-oriented program'
> -       @echo  '  nconfig         - Update current config utilising a ncurses menu based'
> -       @echo  '                    program'
> +       @echo  '  nconfig         - Update current config utilising a ncurses menu based program'

This is OK.


>         @echo  '  menuconfig      - Update current config utilising a menu based program'
>         @echo  '  xconfig         - Update current config utilising a Qt based front-end'
>         @echo  '  gconfig         - Update current config utilising a GTK+ based front-end'
> @@ -169,7 +168,7 @@ help:
>         @echo  '  listnewconfig   - List new options'
>         @echo  '  olddefconfig    - Same as oldconfig but sets new symbols to their'
>         @echo  '                    default value without prompting'
> -       @echo  '  kvmconfig       - Enable additional options for kvm guest kernel support'
> +       @echo  '  kvmconfig       - Enable additional options for kvm guest kernel support'


Could you explain how the indent was broken on your machine?


I think you replaced a tab after kvmconfig
with some spaces.

But, I see tab-indentation in other lines.
(config, menuconfig, tinyconfig, etc.)

If you change this, you should keep "tab vs space" consistent.





>         @echo  '  xenconfig       - Enable additional options for xen dom0 and guest kernel support'
>         @echo  '  tinyconfig      - Configure the tiniest possible kernel'
>         @echo  '  testconfig      - Run Kconfig unit tests (requires python3 and pytest)'
> --
> 2.16.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux