Re: [PATCH v5 0/4] powerpc patches for new Kconfig language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> writes:
> 2018-05-30 23:39 GMT+09:00 Michael Ellerman <mpe@xxxxxxxxxxxxxx>:
>> Nicholas Piggin <npiggin@xxxxxxxxx> writes:
>>
>>> This series of patches improves th powerpc kbuild system. The
>>> motivation was to to be compatible with the new Kconfig scripting
>>> language that Yamada-san has implemented here for merge:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=kconfig
>>>
>>> I have tested on top of that tree, powerpc now builds there.
>>>
>>> To avoid build breakage, the first 3 patches must go before the
>>> kconfig change, and the 4th patch must go after it.
>>>
>>> v5 changes:
>>> - Patch 4 update to syntax changed since kconfig-shell-v3 release.
>>> - Patch 4 suggestions from Masahiro Yamada, remove unnecessary "OK"
>>>   output from check mprofile script, and fold CC_USING_MPROFILE_KERNEL
>>>   into CONFIG_MPROFILE_KERNEL.
>>> - Reduce whitespace disturbance in patch 1.
>>
>> I've put this series in a topic branch.
>>
>>   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/log/?h=topic/kbuild
>
>
> No, you can't.
>
> This series depends on my Kconfig work.

The *last* commit depends on your work, the rest do not.

> You queued it up on v4.17-rc3,
> but necessary patches are not there.
>
> You will get build errors.

I do not get any build errors for the first three commits.

>> I'll plan to merge the first three into the powerpc tree.
>
> Please do not do this.
>
> You can issue Acked-by instead.

I'd prefer the first three commits were in my tree so they're tested
properly.

> I need all the 4 patches to my tree.
> Otherwise, the git-bisect'ability breaks for PowerPC.

You should merge all 4 into your tree, ie. all of my topic/kbuild
branch.

And, I'll merge the first 3 into my tree.

There should be no bisection breakage as a result.

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux