On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson <ulfalizer@xxxxxxxxx> wrote: > On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson <ulfalizer@xxxxxxxxx> wrote: >> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >>> Will the following be equal: >>> >>> $(foo,abc,$(x),$(y)) >>> $(foo, abc, $(x), $(y)) >>> >>> make is rather annoying as space is significant, but there seems no good reason >>> for kconfig to inheritate this. >>> So unless there are good arguments consider alloing the spaces. >>> If the current implmentation already supports optional spaces then I just missed >>> it whie reviewing. >>> >>> Sam >> >> +1 from me. >> >> I also find the rules for whitespace in Make confusing, and always >> have to look them up when doing trickier stuff. Maybe they're the >> result of people not considering whitespace initially, and stuff >> getting tacked on later. GNU Make adds some alternate syntaxes with >> quotes. >> >> I was going to mention shell, but it looks like you already did. :) >> >> If we go with Make-like syntax, maybe we could at least have a variant >> with fewer whitespace gotchas. >> >> Cheers, >> Ulf > > Maybe it'd be a pain to implement, but something like $(foo $(x) "two > words" "interpolated $(stuff)") seems pretty nice, with three > arguments there. Guess that might interact poorly with $(shell foo "bar baz") though. Kinda nice to have a syntax that doesn't overlap with shell when building shell commands. Still wondering if you could get rid of some of the Make gotchas without losing other stuff... Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
