Hi Masahiro On Sun, May 20, 2018 at 05:16:52PM +0900, Masahiro Yamada wrote: > The mconf (or its infrastructure, lxdiaglog) depends on ncurses. > Move and rename check-lxdialog.sh to mconf-cfg.sh to make it work in > the same way as for qconf and gconf. > > According to Randy's report, we still need to carry the fallback code > in case the pkg-config fails to find ncurses. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > --- > - > -# Use recursively expanded variables so we do not call gcc unless > -# we really need to do so. (Do not call gcc as part of make mrproper) > -HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \ > - -DLOCALE ... > # Add environment specific flags > -HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCC) $(HOSTCFLAGS)) > -HOST_EXTRACXXFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCXX) $(HOSTCXXFLAGS)) > - > +HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCC) $(HOSTCFLAGS)) \ > + -DLOCALE > +HOST_EXTRACXXFLAGS += $(shell $(CONFIG_SHELL) $(srctree)/$(src)/check.sh $(HOSTCXX) $(HOSTCXXFLAGS)) \ > + -DLOCALE Any chance that the ugly hack in check.sh could be ported over to use pkg-config? There should be no need to specify both $(shell ...) AND $(CONFIG_SHELL) This was not introduced by this commit, but as the Makefile is cleaned up include this too. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
