On Tue, 15 May 2018 15:24:21 +1000 Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > > Have you tried building all current archs with function tracing enabled > > to make sure this doesn't break any of them? I can do it if you want. > > We shouldn't need to should we? This is only touching powerpc specific > code (if I understand perl that is). > > eg: > > $ git diff -U9 scripts/recordmcount.pl Thanks for the added context! Yeah, I don't look at that code much anymore since I mainly deal with recordmcount.c now-a-days. I wonder if someone should port ppc to that. It is also no my todo list to merge that with objtool. Anyway, Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> -- Steve > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > index 191eb949d52c..3c67304a7425 100755 > --- a/scripts/recordmcount.pl > +++ b/scripts/recordmcount.pl > @@ -268,18 +268,25 @@ if ($arch eq "x86_64") { > } elsif ($arch eq "powerpc") { > $local_regex = "^[0-9a-fA-F]+\\s+t\\s+(\\.?\\S+)"; > # See comment in the sparc64 section for why we use '\w'. > $function_regex = "^([0-9a-fA-F]+)\\s+<(\\.?\\w*?)>:"; > $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\s\\.?_mcount\$"; > > if ($bits == 64) { > $type = ".quad"; > } > + if ($endian eq "big") { > + $cc .= " -mbig-endian "; > + $ld .= " -EB "; > + } else { > + $cc .= " -mlittle-endian "; > + $ld .= " -EL "; > + } > > } elsif ($arch eq "arm") { > $alignment = 2; > $section_type = '%progbits'; > $mcount_regex = "^\\s*([0-9a-fA-F]+):\\s*R_ARM_(CALL|PC24|THM_CALL)" . > "\\s+(__gnu_mcount_nc|mcount)\$"; > > } elsif ($arch eq "arm64") { > $alignment = 3; > > > cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html