On Thu, 15 Mar 2018, Masahiro Yamada wrote:
> From the comment, I expect this code creates autoksyms.h in case it
> is missing, but it actually touches it when it does exists.
Oops, indeed.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> I do not know when this code is useful...
>
> If autoksyms.h were missing, build should have already failed because
> include/{linux,asm-generic}/export.h need it.
>
> Maybe for standalone test?
> Or, in order to make this script self-contained?
I agree it isn't very useful. Proof: it was wrong and wouldn't have
worked as intended. So the best fix might be to simply remove that line.
>
>
> scripts/adjust_autoksyms.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index 513da1a..a52210b 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -49,7 +49,7 @@ case "${KCONFIG_CONFIG}" in
> esac
>
> # In case it doesn't exist yet...
> -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
> +if [ ! -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
>
> # Generate a new ksym list file with symbols needed by the current
> # set of modules.
> --
> 2.7.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
