On Fri, Feb 23, 2018 at 3:04 PM, Eugeniu Rosca <erosca@xxxxxxxxxxxxxx> wrote: > > Hi Masahiro, > > On Fri, Feb 23, 2018 at 09:10:37PM +0900, Masahiro Yamada wrote: >> Eugeniu, >> >> >> 2018-02-21 15:10 GMT+09:00 Eugeniu Rosca <roscaeugeniu@xxxxxxxxx>: >> >> > >> > I've tested https://patchwork.kernel.org/patch/10229545/ and >> > https://patchwork.kernel.org/patch/10231295/ and they work great for me. >> > Thank you for this feature. >> > >> >> I will give you that code in the second one. > > I appreciate that, although I am open minded who takes the authorship. > This feature makes my life easier and that's the most important part. > >> >> Please fill the commit log with yours, >> and also fix the bugs pointed by Petr. > > Sure. Will do that. > >> Anyway, I will claim my contribution >> in the form of Signed-off-by when I pick it up. :) > > I have one side question loosely related to this patch. > > Reverse dependencies are still not printed in zconfdump() (used in our kernel > team for e.g. cross platform .config alignment/comparison). My gut feeling > tells me this is mainly caused by the extremely unfriendly unreadable > expressions which is how reverse dependencies used to be represented before > commit 1ccb27143360 ("kconfig: make "Selected by:" and "Implied by:" > readable"). Since this is now greatly improved, would you mind printing > Selected/Implied-by in zconfdump? There are also other zconfdump fixes > sitting in my local branch, like https://patchwork.kernel.org/patch/9253535/ . > I would like to push them to you (they probably deserve a separate > thread), if you think this is appropriate. > > Best regards, > Eugeniu. Shameless plug: If you need to do any fancy Kconfig parsing and comparison, then Kconfiglib (https://github.com/ulfalizer/Kconfiglib) might be handy. It makes it easy to walk the menu tree, print and inspect symbols and expressions, etc. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
