Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> >> 'default N' should be 'default n', though they happen to have the same
> >> effect here, due to undefined symbols (N in this case) evaluating to n
> >> in a tristate sense.
> >>
> >> Remove the default instead of changing it. bool and tristate symbols
> >> implicitly default to n.
> >
> > s/bool/Bool/
> 
> Not a great excuse, but I was thinking syntactically -- 'bool' and
> 'tristate' symbols... :)
> 
> >
> >> Discovered with the
> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> >> script.
> >>
> >> Signed-off-by: Ulf Magnusson <ulfalizer@xxxxxxxxx>
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >
> > Since only this patch was posted to linux-pci, I assume it will be merged
> > via some other tree.
> 
> I didn't have a particular tree in mind for this patchset. I imagined
> people would pick up patches into the trees where they make the most
> sense, and only created the patchset to keep track of the patches more
> easily. Might have created some confusion in retrospect.
> 
> I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> individual patches by the way.

OK, then either Lorenzo or I will pick it up.

It's in drivers/pci/host/, so ideally Lorenzo will take it since he
looks after everything else in there.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux