On 01/15/18 15:09, Petr Vorel wrote: > rev_dep expressions can get rather unwieldy, especially if a symbol is > selected by more than a handful of other symbols. I.e. it's possible to > have near endless expressions like: > A && B && !C || D || F && (G || H) || [...] > > Chop these expressions into actually readable chunks: > - A && B && !C > - D > - F && (G || H) > - [...] > > I.e. transform the top level OR tokens into newlines and prepend each > line with a minus. This makes the "Selected by:" blurb much easier to > read. For consistency the same is done for "Depends on:" although the > problem isn't that bad for it. This is done only if there is more than > one top level OR. > > This also prevents trimming too long lines. > > Based on idea from Paul Bolle. > > Reported-by: Paul Bolle <pebolle@xxxxxxxxxx> > Signed-off-by: Petr Vorel <petr.vorel@xxxxxxxxx> > --- > Tested on search USB and General setup -> Kernel compression mode (Gzip) -> Help. > > Changes v3->v4: > * Add split also for "Depends on:". This is done for consistency (reported > by Masahiro Yamada). I didn't consider other symbols which call expr_gstr_print() > as reasonable candidates (i.e. "Implies:" and "Range : "). > * Add new line and hyphen only when there are more top level OR than one. > --- > scripts/kconfig/expr.c | 16 +++++++++++++--- > scripts/kconfig/menu.c | 4 ++++ > 2 files changed, 17 insertions(+), 3 deletions(-) > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
