On Sat, Jan 06, 2018 at 12:17:40PM -0800, Martin Kelly wrote: > On 12/23/2017 02:16 PM, Martin Kelly wrote: > > On 12/23/2017 01:06 PM, Martin Kelly wrote: > > > From: Martin Kelly <martin@xxxxxxxxxxxxxxxx> > > > > > > Currently in a number of Makefiles, we clobber the CC, LD, and/or > > > STRIP env vars > > > when cross-compiling, which breaks any additional flags that might > > > be set (such > > > as sysroot). This easily shows up by using, for instance, a Yocto SDK. > > > > > > Fix this by more carefully overriding the flags in the way that the perf > > > Makefile does. > > > > > > This patch does not fix cross-compile for all the tools (some have > > > other bugs), > > > but it does appear to fix it for these: > > > > > > - cgroup > > > - freefall > > > - gpio > > > - hv > > > - iio > > > - leds > > > - spi > > > - vm > > > - wmi > > > > > > Signed-off-by: Martin Kelly <martin@xxxxxxxxxxxxxxxx> > > > --- > > > tools/cgroup/Makefile | 1 - > > > tools/gpio/Makefile | 2 -- > > > tools/hv/Makefile | 1 - > > > tools/iio/Makefile | 2 -- > > > tools/laptop/freefall/Makefile | 1 - > > > tools/leds/Makefile | 1 - > > > tools/perf/Makefile.perf | 6 ------ > > > tools/power/acpi/Makefile.config | 3 --- > > > tools/scripts/Makefile.include | 18 ++++++++++++++++++ > > > tools/spi/Makefile | 2 -- > > > tools/usb/Makefile | 1 - > > > tools/vm/Makefile | 1 - > > > tools/wmi/Makefile | 1 - > > > 13 files changed, 18 insertions(+), 22 deletions(-) > > > Hi Martin, This stuff needs to be broken up into one patch per directory and sent to the individual maintainers. Unfortunately, a lot of people haven't filled out MAINTAINERS properly for their tools/ directory so get_maintainer.pl doesn't always select the correct mailing list. Keeping track of the tools/ director is actually a good task for kernel-janitors btw. diff --git a/MAINTAINERS b/MAINTAINERS index 042400542c55..14d93b30aeeb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3625,6 +3625,7 @@ S: Maintained F: Documentation/cgroup* F: include/linux/cgroup* F: kernel/cgroup* +F: tools/cgroup/ CONTROL GROUP - CPUSET M: Li Zefan <lizefan@xxxxxxxxxx> So you might need to manually check MAINTAINERS to find the correct list. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
