2017-12-06 6:23 GMT+09:00 Jim Davis <jim.epost@xxxxxxxxx>: > On Tue, Dec 5, 2017 at 4:43 AM, Paolo Pisati <paolo.pisati@xxxxxxxxxxxxx> wrote: > >>> I noticed that if I tried to make snap-pkg with the O=/some/dir option >>> the tar step failed but the rest of the build continued, and seems to >>> have finished successfully. Should the snap-pkg target stop after a >>> tar failure? >> >> That is weird, how did you do that? > > make O=/some/dir defconfig (or your-config-of-choice) > make O=/some/dir snap-pkg > > The snap-pkg target is calling the src_tar command, which bails when > $(objtree) isn't $(srctree). > > Is $(objtree) = $(srctree) a necessary restriction with snap builds? > It's a restriction for rpm builds for some reason or another, Rather, restriction for our build system. Working directory is changed at the top Makefile if O= is given. This option is propagated to sub-make. > but I > thought that was just a peculiarity of the rpm build process. If the > snap's tarball could be built without using src_tar, like the buildtar > script does, then Bob's your uncle. Probably, you must reset O=, KBUILD_OUTPUT, KBUILD_SRC, etc. before calling rpmbuild, snapcraft, etc. This is not a peculiarity of rpmbuild or snapcraft. I guess things are not so simple as they look at a glance. > Though if the source tree is an essential part of the snap build then > perhaps the build should just exit if the tarball can't be generated > for whatever reason, including users doing weird things :) > I agree, but this is not a problem specific to snap-pkg, so Paolo's work will not be blocked. I sent this patch: https://patchwork.kernel.org/patch/10095377/ Just one question to Paolo: If some change like firmware removal happens in the future, patching for snapcraft is necessary? (i.e. users are required to upgrade snapcraft from --edge ?) I guess the answer is yes, because "plugin: kernel" needs to know the kernel-build system internal. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
