On Thu, Nov 30, 2017 at 09:21:49PM +0900, Masahiro Yamada wrote: > BTW, did this patch work in your test? Yes, but it looks like /bin/sh is symlinked to bash on my system. I can reproduce the issue with dash. > As for the macro names, maybe > > __cc-ifversion, __cc-if-fullversion for consistency? > I think you can do like follows to avoid code duplication. > > # backward compatibility > cc-ifversion = $(gcc-ifversion) > cc-if-fullversion = $(gcc-if-fullversion) Sure, both changes sound good to me. I'll fix these in v2. Sami -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html