On Wed, 29 Nov 2017 15:57:53 -0800 Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > On Wed, Nov 29, 2017 at 3:44 PM, Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote: > > Make sure the linker doesn't remove .altinstructions or > > .altinstr_replacement when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is > > enabled. > > This sounds like a bug in the original implementation of > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION? If so, this can likely get > merged regardless of the rest of the patchset, ie. gold support. Yes, also patch 3/7 probably (thanks for doing these, btw). The LD_DCDE option is actually been broken upstream thanks to lack of time (which is a known issue, this is why no arch enables it). Basically it just needs a bit more effort to go through and ensure nothing is discarded incorrectly, and all new sections are placed into output sections, before each arch is enabled. (Comparing `readelf -S` before/after is a way to spot bugs.) So yes please if it's not too much trouble, could you remove the "gold" name from the generic patch and put it at the front of the series with this arm64 patch. Possibly then you could also do a 3rd patch to allow arm64 to select it if it's working with gcc? Thanks, Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
