RE: [PATCH v2] kbuild: clean up *.dtb and *.dtb.S patterns from top-level Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,


> -----Original Message-----
> From: arndbergmann@xxxxxxxxx [mailto:arndbergmann@xxxxxxxxx] On Behalf Of
> Arnd Bergmann
> Sent: Thursday, November 02, 2017 5:38 PM
> To: Yamada, Masahiro/山田 真弘 <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: DTML <devicetree@xxxxxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> linux-arch <linux-arch@xxxxxxxxxxxxxxx>; open list:RALINK MIPS
> ARCHITECTURE <linux-mips@xxxxxxxxxxxxxx>; Linux Kbuild mailing list
> <linux-kbuild@xxxxxxxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>;
> Ralf Baechle <ralf@xxxxxxxxxxxxxx>; Pantelis Antoniou
> <pantelis.antoniou@xxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> Frank Rowand <frowand.list@xxxxxxxxx>; Linux ARM
> <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2] kbuild: clean up *.dtb and *.dtb.S patterns from
> top-level Makefile
> 
> On Thu, Nov 2, 2017 at 3:51 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> > We need to add "clean-files" in Makfiles to clean up DT blobs, but we
> > often miss to do so.
> >
> > Since there are no source files that end with .dtb or .dtb.S, so we
> > can clean-up those files from the top-level Makefile.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
> 
> On a (barely) related note, I'm struggling with another problem in the
> way we handle
> the .dtb files in arm64 when CONFIG_OF_ALL_DTBS is enabled: when building
> on a lot of CPUs, we try to build the same files from both
> arch/arm64/boot/dts/Makefile
> and arch/arm64/boot/dts/*/Makefile, which then results in a failed
> build when writing
> the temporary files.
> 
> I have come up with a workaround that I use locally, but it seemed too ugly
> to
> submit that for inclusion. Maybe you can come up with a nicer a solution
> for
> this as well?
> 
>       Arnd

Yeah, I had also noticed this race problem on parallel building
with CONFIG_OF_ALL_DTBS.

I was planning to do it
when I come up with a clean implementation.

One idea is to handle dtb-y and CONFIG_OF_ALL_DTBS
natively in scripts/Makefile.build or somewhere
as scripts/Makefile.dtbinst already recognizes dtb-y as a special variable.

��.n��������+%������w��{.n�����{��F���{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��




[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux