On 16/09/2017 08:23, Dmitriy Cherkasov wrote: > On 09/13/2017 11:15 AM, Daniel Lezcano wrote: >> >> All this code must go in the timer side and use the TIMER_OF_DECLARE >> macro with the proper wrappers. > > Hi, thanks for the feedback. > > Agreed. I'll clean this up. > >> >> Where is the request_per_cpu_interrupt()? >> >> What is this riscv_timer_interrupt() signature? > > This arch defines a separate exception type for local timer interrupts. > Currently the interrupt controller driver checks the trap cause > register, determines that it's a timer, and calls the handler directly. > To make this go through the interrupt subsystem, this driver would need > to be reworked. > >> >> Where is get_cycles64() ? > > This is in asm/timex.h. Should this be split into a separate asm header > ala arm64? No, it is fine but may be it is get_cycles(), no get_cycles64(), right? >> The timer driver should be self-contained and not spread across >> different places, it is very difficult to review it. >> >> [ ... ] >> > > Agreed, thanks again for reviewing it anyway :) Ok, thanks. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
