On Tue, 01 Aug 2017 06:06:20 PDT (-0700), andriy.shevchenko@xxxxxxxxxxxxxxx wrote: > On Mon, 2017-07-31 at 17:59 -0700, Palmer Dabbelt wrote: >> Many ports (m32r, microblaze, mips, parisc, score, and sparc) use >> functionally identical copies of various GCC library routine files, >> which came up as we were submitting the RISC-V port (which also uses >> some of these). >> >> This patch adds a new copy of these library routine files, which are >> functionally identical to the various other copies.  These are >> availiable via Kconfig as CONFIG_GENERIC_$ROUTINE, which currently >> isn't >> used anywhere. >> > > >> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> > >> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > >> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> > > That's why we are putting tags before own SoB line(s) OK, sorry about that -- I'll fix it for our v8 patch set. > In two cases in the patch you have > > + > + > > for no reason. I think you may remove second empty line. Makes sense. I'll squash this into the next patch set. diff --git a/include/lib/libgcc.h b/include/lib/libgcc.h index a5397e34e005..32e1e0f4b2d0 100644 --- a/include/lib/libgcc.h +++ b/include/lib/libgcc.h @@ -16,7 +16,6 @@ * to the Free Software Foundation, Inc. */ - #ifndef __LIB_LIBGCC_H #define __LIB_LIBGCC_H diff --git a/lib/ashldi3.c b/lib/ashldi3.c index ff4ec63d2ab6..1b6087db95a5 100644 --- a/lib/ashldi3.c +++ b/lib/ashldi3.c @@ -14,7 +14,6 @@ * to the Free Software Foundation, Inc. */ - #include <linux/export.h> #include <lib/libgcc.h> -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
