Re: [PATCH v2] kbuild: Do not use hyphen in exported variable name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2017-08-20 6:30 GMT+09:00 Ben Hutchings <ben@xxxxxxxxxxxxxxx>:
> This definition in Makefile.dtbinst:
>
>     export dtbinst-root ?= $(obj)
>
> should define and export dtbinst-root when handling the root dts
> directory, and do nothing in the subdirectories.  However some shells,
> including dash, will not pass through environment variables whose name
> includes a hyphen.  Usually GNU make does not use a shell to recurse,
> but if e.g. $(srctree) contains '~' it will use a shell here.
>
> Rename the variable to dtbinst_root.
>
> References: https://bugs.debian.org/833561
> Fixes: 323a028d39cdi ("dts, kbuild: Implement support for dtb vendor subdirs")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
> v2: Revised the commit message to explain exactly how the hyphenated
> variable can be lost.
>

Thanks for figuring out the root cause!

Applied to linux-kbuild/fixes.

-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux