Hi. 2017-08-12 21:00 GMT+09:00 Bjørn Forsman <bjorn.forsman@xxxxxxxxx>: > Hi, > > On 12 August 2017 at 05:26, Masahiro Yamada > <yamada.masahiro@xxxxxxxxxxxxx> wrote: >> Hi. >> >> 2017-07-24 23:20 GMT+09:00 Bjørn Forsman <bjorn.forsman@xxxxxxxxx>: >>> Several places already use pwd and rely on $PATH lookup. Moving the >>> remaining /bin/pwd users over for consistency. >>> >>> Also, a reason for doing /bin/pwd -> pwd instead of the other way around >>> is because I believe build systems should make little assumptions on host >>> filesystem layout. Case in point, we do this kind of patching already in >>> NixOS. >> [...] >> Could you use $(abspath ...) instead of $(shell cd ... && /bin/pwd) ? >> [...] >> This one should use $(realpath ...) instead of $(abspath ...), I think. >> >> The difference between them is that >> $(realpath ...) returns an empty string if the given path does not exist. > > That sounds like possibly changing semantics. I'd prefer to keep the > patch as is, since I'm not familiar with the side effects of inserting > relative vs absolute paths here. Is that OK for you? > I prefer abspath/realpath. If you are reluctant to do it, I will take a look. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
