Hi Nicolas 2017-05-20 20:27 GMT+09:00 Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>: > When compiling with -Wsuggest-attribute=format in HOSTCFLAGS, gcc > complains that error_with_pos() may be declared with a printf format > attribute: > > scripts/genksyms/genksyms.c:726:3: warning: function might be > possible candidate for ‘gnu_printf’ format attribute > [-Wsuggest-attribute=format] > vfprintf(stderr, fmt, args); > ^~~~~~~~ > > This would allow catching printf-format errors at compile time in > callers to error_with_pos(). Add this attribute. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx> > --- > > I am sending this to the maintainers listed in section "KERNEL BUILD + > files below scripts/ (unless maintained elsewhere)" even though it does > not list scripts/genksyms/. Should this directory be added in > MAINTAINERS? scripts/genksyms/ is not explicitly listed in MAINTAINERS. So, patches that touch scripts/genksyms/ basically should go to the kbuild tree by the rule "files below scripts/ (unless maintained elsewhere)". I will apply this patch shortly. Thanks. If somebody offers to maintain scripts/genksyms/, I am totally fine with it. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
