Hi, Thanks for taking time to review. On 18 April 2017 at 17:31, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: > Before expanding this even more, > please help me understand this script. > > Commit 3716001b implemented source package build > at the end of the builddeb script. > However, the binary packages are still built in its own way. > (So, debian/rules is not used in general workflows, > so we need to test it explicitly somehow.) Historic reasons.. since the builddeb already existed, the easiest way to implement debian/rules was to make a skeleton debian/rules that calls builddeb indrectly. > Why do not we create a source package first, > then build binary packages from it? I wouldn't do a source package per se, but we could create a debian/ directory tree and the call dpkg-buildpackage. This would be a more substantial overhaul that might break some expected behavior of deb-pkg targets. If people think its worth, I can give it a shot. > rpm-pkg does that way. > (generate a spec-file, then run rpmbuild) speaking of the mkspec script, it would be nice to refactor it to here documents over endless lines of echo. Riku -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
