Hi Luis, 2017-03-15 9:53 GMT+09:00 Luis R. Rodriguez <mcgrof@xxxxxxxxxx>: > On Sat, Mar 11, 2017 at 02:37:02PM +0900, Masahiro Yamada wrote: >> Hi Luis, >> >> >> 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@xxxxxxxxxx>: >> > If you modify the target asm we currently do not force the >> > recompilation of the firmware files. The target asm is in >> > the firmware/Makefile, peg this file as a dependency to >> > require re-compilation of firmware targets when the asm >> > changes. >> > >> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> >> > --- >> > >> > Michal, >> > >> > I had this patch as part of my linker table series [0] but have split it >> > off as its a small atomic separate change and can go in separately. Greg >> > prefers this be reviewed by the kbuild tree so sending it your way. >> > This v2 has no modifications, just resending it to the kbuild tree. >> > >> > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@xxxxxxxxxx >> > >> > firmware/Makefile | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/firmware/Makefile b/firmware/Makefile >> > index e297e1b52636..fa3e81c2a97b 100644 >> > --- a/firmware/Makefile >> > +++ b/firmware/Makefile >> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ >> > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ >> > include/config/ppc32.h include/config/ppc64.h \ >> > include/config/superh32.h include/config/superh64.h \ >> > - include/config/x86_32.h include/config/x86_64.h) >> > + include/config/x86_32.h include/config/x86_64.h \ >> > + firmware/Makefile) >> > >> > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) >> > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) >> >> >> Why don't you use $(call filechk,...) or $(call if_changed,...) >> instead of wordsize_deps ? > > Care to send a patch? Sorry for my late reply. Yes, if you want, I will give it a try. But, please wait until this weekend... -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
