Re: [PATCH] kconfig/nconf: Fix hang when editing symbol with a long prompt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 24, 2016 at 10:10:23PM +0000, Ben Hutchings wrote:
> Currently it is impossible to edit the value of a config symbol with a
> prompt longer than (terminal width - 2) characters.  dialog_inputbox()
> calculates a negative x-offset for the input window and newwin() fails
> as this is invalid.  It also doesn't check for this failure, so it
> busy-loops calling wgetch(NULL) which immediately returns -1.
> 
> The additions in the offset calculations also don't match the intended
> size of the window.
> 
> Limit the window size and calculate the offset similarly to
> show_scroll_win().
> 
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Fixes: 692d97c380c6 ("kconfig: new configuration interface (nconfig)")
> Signed-off-by: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx>

Applied to kbuild.git#kconfig, thanks.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux